rpaths strike again, please add checker to koji/mock

[Julian Sikorski]

W dniu 25.06.2011 23:43, Adam Williamson pisze:
> On Sat, 2011-06-25 at 22:06 +0200, Julian Sikorski wrote:
>> W dniu 25.06.2011 18:58, Adam Williamson pisze:
>>> On Sat, 2011-06-25 at 13:56 +0200, Julian Sikorski wrote:
>>>> Hi,
>>>>
>>>> currently the existence of RPATHS is only checked when one does a local
>>>> rpm build. mock and koji still let it slide. As a result we have these bugs:
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=703636
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=716572
>>>> I provided a patch for the first one and even applied for package commit
>>>> access to apply the fix, yet the maintainers choose to ignore me.
>>>
>>> Well, it's fairer to assume the maintainer is simply busy and hasn't got
>>> to the bug yet than to assume they're ignoring you.
>>>
>>> Note that your patch isn't the best fix; it would be better to use the
>>> --disable-rpath configure parameter. I meant to push a build this week
>>> which would fix this but didn't get around to it yet...
>>
>> My patch is not the best fix, true. The problem is that --disable-rpath
>> does not work as advertised and using the sed command from the Fedora
>> wiki prevents cheese from building at all. It is all written down in the
>> bug.
> 
> Last I read, --disable-rpath worked if you did an autoreconf too? That
> would still be the most preferable option, I believe...
I just checked again.
- autoreconf does not seem to make a difference
- ./autogen.sh is enough to remove rpaths, --disable-rpath is not needed
anymore.
If running ./autogen.sh is preferred to chrpath, then I think this
should be documented in the wiki. I had exactly the same issue with
gnome-chemistry-utils long time ago and I ended up using chrpath.

Julian