Reviews done, approval pending
Tomasz Torcz
tomek at pipebreaker.pl
Fri Oct 28 15:02:00 UTC 2011
On Fri, Oct 28, 2011 at 08:39:56AM -0500, Richard Shaw wrote:
> > ndjbdns -> https://bugzilla.redhat.com/show_bug.cgi?id=480724
> >
> > Could someone approve these packages please?
>
> As for ndjbdns, I'm not quite comfortable with that one. Although I
> hate to mention it because it looks like so much work has already been
> done, I will make one recommendation for it. You probably need to
> create systemd unit files for the tools since it is the default as of
> F15. You can use some %if logic in the spec to use one spec file for
> all releases, i.e.: "%if 0%{?fedora} > 14 ..."
Additionaly, I believe daemontools feature are subset of systemd's one.
So daemontools shouldn't be needed at all.
--
Tomasz Torcz "Funeral in the morning, IDE hacking
xmpp: zdzichubg at chrome.pl in the afternoon and evening." - Alan Cox
More information about the devel
mailing list