Reviews done, approval pending

P J P pj.pandit at
Fri Oct 28 17:33:36 UTC 2011

   Hello Richard,

----- Original Message -----
> From: Richard Shaw <hobbes1069 at>
> I've just made some comments for PFDCrack, I'll take it once you've
> made the updates.

  Ah cool, thanks.

> As for ndjbdns, I'm not quite comfortable with that one. Although I
> hate to mention it because it looks like so much work has already been
> done, I will make one recommendation for it. You probably need to
> create systemd unit files for the tools since it is the default as of
> F15. You can use some %if logic in the spec to use one spec file for
> all releases, i.e.: "%if 0%{?fedora} > 14 ..."

  Yeah, even Rahul suggested that one. I'll fix it asap.

Thanks a lot.


More information about the devel mailing list