[antlr3] fix build on other arches

Jerry James loganjerry at gmail.com
Fri Sep 9 18:06:30 UTC 2011


On Fri, Sep 9, 2011 at 11:30 AM, Dan Horák <sharkcz at fedoraproject.org> wrote:
> commit ee88cf13670b752fc9fa94f39b1b2e2fe97849c3
> Author: Dan Horák <dan at danny.cz>
> Date:   Fri Sep 9 19:30:19 2011 +0200
>
>    fix build on other arches
>
>  antlr3.spec |   15 +++++++++------
>  1 files changed, 9 insertions(+), 6 deletions(-)
> ---
> diff --git a/antlr3.spec b/antlr3.spec
> index 48daab3..9e86cca 100644
> --- a/antlr3.spec
> +++ b/antlr3.spec
> @@ -9,7 +9,7 @@
>  Summary:                       ANother Tool for Language Recognition
>  Name:                          antlr3
>  Version:                       %{antlr_version}
> -Release:                       14%{?dist}
> +Release:                       15%{?dist}
>  URL:                           http://www.antlr.org/
>  Source0:                       http://www.antlr.org/download/antlr-%{antlr_version}.tar.gz
>  Source1:                       http://www.antlr.org/download/C/libantlr3c-%{antlr_version}.tar.gz
> @@ -203,11 +203,11 @@ popd
>  # Build the C runtime
>  pushd libantlr3c-%{antlr_version}
>
> -%ifarch x86_64 ppc64
> -%configure --disable-abiflags --enable-debuginfo --enable-64bit
> -%endif
> -%ifarch %{ix86} ppc
> -%configure --disable-abiflags --enable-debuginfo
> +%configure --disable-abiflags --enable-debuginfo \
> +%ifarch x86_64 ppc64 s390x sparc64
> +    --enable-64bit
> +%else
> +    %{nil}
>  %endif

[snip]

FWIW, in the couple of packages I maintain where configure isn't smart
enough to figure out 32- vs. 64-bitness on its own (e.g., csdp), I've
done this to be (hopefully) future-architecture-proof:

if [ %{__isa_bits} = "64" ]; then
   magic_command_to_enable_64_bit_build
fi

It might be nice to encapsulate that in an RPM macro so that the above
could read something like this:

%configure --disable-abiflags --enable-debuginfo \
%ifarch64
    --enable-64bit
%else
    %{nil}
%endif

Regards,
-- 
Jerry James
http://www.jamezone.org/


More information about the devel mailing list