Packaging Guidelines - creating tarball from VCS with script

[Conan Kudo (ニール・ゴンパ)]

I agree with Toshio on this. Depending on how the VCS behaves with
checkout/cloning, it will be difficult to get predictable results in a
usable way through a script. Commenting in the spec file is the best way to
go in my opinion.
On May 14, 2012 9:22 AM, "Toshio Kuratomi" <a.badger at gmail.com> wrote:

> On Mon, May 14, 2012 at 03:02:23PM +0200, Tomas Radej wrote:
> > Hi,
> >
> > I was wondering if Packaging Guidelines could be amended so that even
> when
> > creating tarball from VCS, using a standalone shell script would be
> > mandatory (see
> > http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
> > ). I believe this could allow easier reviews and package updates as there
> > would be no need to copy&paste code from comments, and checking for
> > package's checksum could be (at least partially) automated for the
> > fedora-review tool.
> >
> > What do you think?
> >
> Automating of the package's checksum won't work for many VCS's .  git, for
> instance, does not preserve timestamps.  So the tarball created from a git
> snapshot will have a different checksum for each checkout.
>
> I personally prefer to have the checkout instructions in comments.  It
> makes
> it easier to review what the person did and interrupts my thoughts less
> when
> I can see what the person did to produce the tarball in the same window as
> I'm looking at the spec file.  Having to open up a second file to see if
> the
> checkout commands are hitting the canonical source repository and that they
> contain enough information to checkout only a single version is
> a distraction.
>
> -Toshio
>
> --
> devel mailing list
> devel at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/devel/attachments/20120514/64a70765/attachment.html>