Evolving standards for unpacked sources

[Richard W.M. Jones]

On Wed, May 30, 2012 at 12:13:42PM -0400, Adam Jackson wrote:
> On 5/30/12 9:33 AM, Peter Jones wrote:
> 
> >diff --git a/ocaml.spec b/ocaml.spec
> >index bbf2669..2ab0ecc 100644
> >--- a/ocaml.spec
> >+++ b/ocaml.spec
> >@@ -233,9 +233,13 @@ man pages and info files.
> >git init
> >git config user.email "noone at example.com"
> >git config user.name "no one"
> >+git config sendemail.to "%{name}-owner at fedoraproject.org"
> >git add .
> >git commit -a -q -m "%{version} baseline"
> >git am %{patches}
> 
> Sorry for the hijack, but this should be written as:
> 
> git am %{patches} < /dev/null
> 
> Otherwise in the admittedly lovely case where you have no patches to
> apply, your package will build in mock (because the standard fds are
> already thus redirected) but normal fedpkg commands will hang.

Thanks, fixed in git.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top