macros.cmake: set -DCMAKE_BUILD_TYPE=ReleaseWithDebInfo by default

[Richard Shaw]

On Mon, Nov 12, 2012 at 11:14 PM, Ralf Corsepius <rc040203 at freenet.de>wrote:

> On 11/13/2012 05:05 AM, Richard Shaw wrote:
>
>> I own several packages that use cmake and I've taken to setting the
>> release type to RelWithDebugInfo like you suggest. One question I've had
>> but never gotten around to asking is: Regardless of whether you use
>> Release or RelWithDebugInfo, should we be building with -O3? It seems
>> odd that the rpm macro defaults to doing something that is explicitly
>> against the packaging guidelines.
>>
>
> Your sentence confuses me or I am missing somthing.
>
> The FPG intention is to mandate using RPM_OPT_FLAGS. These so far have
> contained -O2. So, unless something has recently been changed, using -O3
> would qualify as a bug somewhere.


I'd have to go back and look but the last flag wins, right? I've had cmake
projects where RPM_OPT_FLAGS was used but the cmake options were appended,
so I ended up with -O3...

Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/devel/attachments/20121113/7c05ca20/attachment.html>