fedpkg / koji error

[Thorsten Leemhuis]

Lo!

On 09.10.2012 20:03, Jesse Keating wrote:
> On 10/09/2012 07:14 AM, Simone Caronni wrote:
>> On 19 September 2012 00:26, Orion Poplawski <orion at cora.nwra.com> wrote:
>>> On 09/05/2012 08:07 PM, Tom Callaway wrote:
>>>> Jesse, I'm not sure if you're still the correct upstream here, please
>>>> correct me if you're not, and I'll send the patch somewhere else.
>>> This helps me a lot as well building el srpms from master with "fedpkg
>>> --dist el6 srpm".  +1 from me.
>> Any news regarding this? Is the patch planned to be included?
>> I don't see any activity in git: http://git.fedorahosted.org/cgit/fedpkg.git/
> Oops.  I dropped the ball.  Spot even pinged me about it and I made a 
> promise I didn't keep.  Rectifying.

Patch was integrated and a updated fedpkg is in updates-testing
currently -- which leads to wayland support in mesa.spec being not build
when you build it with fedpkg, as it contains this %configure statement:

> --with-egl-platforms=x11,drm%{!?rhel:,wayland} \

The ",wayland" is not added, as rhel is defined now as 0 when building
with fedpgk. If you build a srpm and try to build it with rpmbuild then
it works, as it's not defined there. I explained it in more detail in
https://bugzilla.redhat.com/show_bug.cgi?id=867375 , which made me
brining up the issue here, as Jesse was unsure how to proceed.

I'd say the current behaviour is the quite bad, as it leads to different
results when building with fedpkg and rpmbuild on F18. The real fix
afaics would be to revert the change and, if wanted, define rhel as 0 in
Fedora's redhat-rpm-config, too -- but then we obviously need to fix all
%{!?rhel:foo} statements in current spec files.

Options? Spot, Simone?

CU
knurd