really stop "really" commits (really!)

[Lukas Zapletal]

On Mon, Dec 16, 2013 at 03:10:08AM -0700, T.C. Hollingsworth wrote:
> > I do commit locally
> > although I probably don't want push the snapshot sources, because I update
> > them later, when time comes.

+1

> This should happen rarely enough that having to use `git commit
> --no-verify` to bypass it wouldn't be too much trouble?

I am all for these kinds of checks and I appreciate your effort. These
are all good ideas, but please let's do not do this on the git level.
This is not appropriate place when we already have a nice layer for this
kinds of tests: fedpkg.

Every time a maintainer want to build a package using fedpkg, we can add
this kind of hooks and verify what is necessary in the similar form you
recommend (with the option to skip). Let's build a new command fedpkg
check to do explicit checks as well which can help when fixing those
mistakes.

We do not want to get to the state when packages being committed are
automatically being built in koji (using git hooks). Because what you
recommend here effectively leads to this "happy" ending - you might
unintentionally seed this kind of approach. I was already there and
believe me - this is not what we want to do. :)

LZ

-- 
Later,

 Lukas "lzap" Zapletal
 irc: lzap #theforeman