PSA: If you are C/C++ developer, use cppcheck

[Dan Williams]

On Tue, 2013-12-17 at 12:17 -0500, Rahul Sundaram wrote:
> Hi
> 
> In the last few days, I have been running cppcheck on quite a few programs
> including systemd, transmission, libvirt,  ndjbdns etc and cppcheck has
> found real and potential bugs (null pointer dereferences, uninitialized
> variables, memory & resource leaks etc) in each of them.  I have reported
> the ones I found and several developers have already fixed the issues.   A
> couple of examples

How are you running it to get it to print the warnings?  I've tried
--enable=warning, but all I get are includes errors (like <errno.h>)
that aren't useful and are wrong AFAICT.

Dan

> http://cgit.freedesktop.org/systemd/systemd/commit/?id=e985665d2d226cb42b52bfcad6fd5b1586ad57d7
> 
> https://github.com/pjps/ndjbdns/commit/ee4112a702e22d447d9cd7bd31b880eacfe59a5e
> 
> You might also consider add a build target for regular checks
> 
> http://cgit.freedesktop.org/systemd/systemd/commit/?id=16f4efb4150c65e3c61adaa8ea512489de49f532
> 
> That would be all.  Thanks
> 
> Rahul