--Wl, -z, relro in LDFLAGS required?/Inconsistency when not using %configure

[Michael Schwendt]

On Tue, 22 Oct 2013 11:26:18 +0300, Ville Skyttä wrote:

> In many cases the values aren't picked up from the environment but
> need to be passed in by other means (such as arguments to make etc).

Okay. "make -e …" could be run in that case as a work-around. But
overriding Makefile variables completely can be less than ideal (this
can be observed in some spec files where the packagers also adds the
libs to link with, so the build doesn't break). Better would be that
the Makefile inherits from values passed in via Make or the env.

When using %configure always, even if not available, that makes it
possible to reuse the env vars it defines, and one doesn't need to
access the RPM macros:

  %configure || :
  make CFLAGS="$CFLAGS" LDFLAGS="$LDFLAGS"

To repeat from the earlier reply, one may want to take precautions,
so when a future upgrade adds a configure script, one drops the '|| :'.