Packages with missing %check

Adam Williamson awilliam at redhat.com
Thu Feb 27 02:50:56 UTC 2014


On Wed, 2014-02-26 at 21:53 +0000, Richard W.M. Jones wrote:
> On Wed, Feb 26, 2014 at 04:58:43PM +0100, Miloslav Trmač wrote:
> > 2014-02-26 14:11 GMT+01:00 Colin Walters <walters at verbum.org>:
> > 
> > > During making glib changes you should run glib unit tests to have some
> > > basic level of assurance you didn't introduce regressions or unwanted
> > > changes.
> > >
> > > The *very first* test I run is "does the OS still boot"?  That's called
> > > "smoketest" for me, and it only takes a few minutes.
> > >
> > 
> > That seems to be optimizing for bugs that break the boot, when bugs that
> > occur in less-frequently used parts of the system are far more common; a
> > lot of software is not used, or not critical, in the boot path.
> 
> But bugs which break the boot prevent you from testing everything else.
> 
> Libguestfs currently is the de-facto test of bugs that break the boot,
> and TBH it's not a job I enjoy having.

Er. There are quite a lot of us running Rawhide, y'know. We tend to
notice when our systems stop booting as well.

>   It happens too often in
> Rawhide, and a simple test (in %check or elsewhere) could fix it.

You can't really test a system boot in a package's %check. That's very
definitely not what it's for.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net



More information about the devel mailing list