a questionable dependency chain

[Cole Robinson]

On 01/29/2014 09:32 AM, Christophe Fergeau wrote:
> Hey,
> 
> On Wed, Jan 29, 2014 at 09:21:22AM -0500, Matthias Clasen wrote:
>> I've switched to rawhide yesterday, and discovered that vinagre now
>> forces rsyslog onto my system. That's not great.
>>
>> The dependency chain goes something like this:
>>
>> vinagre -> spice -> libcacard -> ... glusterfs ... ->
>> rsyslog-mmjsonparse -> rsyslog
>>
>> I think there's at least two questionable links in this chain:
>>
>> - why does libcacard need glusterfs ?
> 

This is https://bugzilla.redhat.com/show_bug.cgi?id=987441

> Looking at nm output for libcacard.so, I did not see symbols that were
> obviously related to glusterfs there. However, at build time, libcacard
> ld command line gets a lot of -lxx, including glusterfs libraries.
> libcacard is a sub-package of qemu, so I suspect what's happening is
> it gets linked with all the libraries qemu needs.
> 
> This patch seems to help there and get rid of the extra libraries in ldd
> output (did not try an rpm build to check the deps there).
> 
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 47827a0..9fa297c 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -24,7 +24,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
> 
>  libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
>         -export-syms $(SRC_PATH)/libcacard/libcacard.syms
> -libcacard.la: LIBS += $(libcacard_libs)
> +libcacard.la: LIBS = $(libcacard_libs)
>  libcacard.la: $(libcacard-lobj-y)
>         $(call LINK,$^)
> 

Thanks Christophe! Can you (or elmarco, or alevy), forward that to qemu-devel?

- Cole