pam_script review

Lubomir Rintel lkundrak at v3.sk
Sat Jun 21 11:42:11 UTC 2014


On Sat, 2014-06-21 at 01:12 +0000, Jason Taylor wrote:
> Hi Lubomir,
> 
> Thank you for the information! As suggested, I took a look at a couple of package submissions.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1111692
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1111691
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1111689
> 
> Any tips/hints regarding reviews are appreciated!

Please don't top-post here :)

The reviews look fine, and so does your package. I'll be doing a
complete review shortly.

Thank you.
Lubo

> 
> Regards,
> 
> JT
> ________________________________________
> From: devel-bounces at lists.fedoraproject.org [devel-bounces at lists.fedoraproject.org] on behalf of Lubomir Rintel [lkundrak at v3.sk]
> Sent: Wednesday, June 18, 2014 3:20 PM
> To: Development discussions related to Fedora
> Subject: Re: pam_script review
> 
> Hi Jason,
> 
> On Wed, 2014-06-18 at 18:53 +0000, Jason Taylor wrote:
> > Hi All,
> >
> > I have submitted https://bugzilla.redhat.com/show_bug.cgi?id=1110913
> 
> I've added some comments. If noone else steps in, I can do a formal
> review as well.
> 
> > As indicated in the ticket this is my first packaging attempt so I am
> > looking for a sponsor as well. i would obviously like to learn more
> > about packaging and help maintain packages in addition to my
> > submission. So if someone happens to have the time to help me learn
> > the ropes and can sponsor me so I can see about helping out I would
> > appreciate it! TIA.
> 
> Most sponsors (me included) would like to see you do some informal
> package reviews. Please have a look at the open reviews and if you
> identify any issues with the packages comment on the packages (with a
> note that you're not doing a formal review). You can follow up in this
> thread with the links to your review comments.
> 
> Also, feel free to ask on this list if there's anything unclear about
> the guidelines. The guidelines and documentation are huge and the best
> way to get familiar with them is reviewing and creating the packages.
> 
> > Regards,
> >
> > JT
> 
> Have a nice day!
> Lubo
> 
> --
> devel mailing list
> devel at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
> Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct




More information about the devel mailing list