Let's close the remaining merge reviews

Marcela Mašláňová mmaslano at redhat.com
Wed Mar 26 17:39:14 UTC 2014


On 03/26/2014 08:46 AM, Parag N(पराग़) wrote:
> Hi,
>
> On Wed, Mar 26, 2014 at 5:38 PM, Richard W.M. Jones <rjones at redhat.com> wrote:
>> On Wed, Mar 26, 2014 at 08:13:24AM +0530, Parag N(पराग़) wrote:
>>> If those packages are still not following current packaging guidelines
>>> then they should not be closed otherwise what is the use of FPC and
>>> their work, meetings, updating wiki pages all these efforts will be of
>>> no use then for existing packages in Fedora. FPC work will remain only
>>> for newer package submissions.
>>
>> The presence of these bugs tells you nothing about the quality of
>> those packages.  Also it doesn't tell you about other packages that
>> might have passed the review 5+ years ago, but since then fallen out
>> of compliance with the guidelines.
>>
>
> This looks like a general opinion on package reviews and not about
> merge-reviews.
> Why can't we consider them like as a new reviews? and why people so
> against merge-review just because we got those packages already in
> Fedora?
>
>> This is where having some sort of automated testing of all packages
>> would be good (perhaps running fedora-review over packages, as was
>> suggested in this thread already).
>
> That will be a welcome move but again will maintainers read those
> reviews and work on to fix any reported issues?
>
>
>> FWIW, Debian does this already: http://lintian.debian.org/
>
> Those who want to see all the automated work, keep looking into
> https://fedoraproject.org/wiki/Env_and_Stacks/Changes_Drafts/Automated_packages_review_tools
>
> Regards,
> Parag.
>
I don't care much about Merge reviews. From my POV it doesn't make sense 
to do them, when we have a lot of packages, which went through Merge 
review years ago and can be against Guidelines again.
I would rather invest our free time on automation.

Marcela


More information about the devel mailing list