Review swap

[Michael Schwendt]

On Wed, 19 Nov 2014 11:47:30 +0100, Lorenzo Dalrio wrote:

> Hello,
> I have this trivial package ready to be reviewed
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1165584
> 
> I'd be happy to review one in exchange.

We may need to redefine "trivial" for this one. ;-)
Look:

 | Version:        20141118git%{shortcommit}
 | Release:        1%{?dist}

You would be better off if you followed Fedora's versioning guidelines
for snapshots,

  https://fedoraproject.org/wiki/Packaging:Guidelines#Version_and_Release
  https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag

where you include the date of the checkout in the "Release" tag instead
of the "Version" tag. If there hasn't been an official _version_ yet,
choose "Version: 0". This gives you much more flexibility when dealing
with future updates (not limited to upgrades/downgrades).