Review swap

Michael Schwendt mschwendt at gmail.com
Thu Nov 20 11:11:09 UTC 2014


On Wed, 19 Nov 2014 21:13:29 +0100, Lorenzo Dalrio wrote:

> In my hurry I have swapped Version and Release following exactly the
> guidelines you have linked. :-/

Well, a package being tiny does not imply there's nothing to be reviewed.

The top of the executable says

  __version__ = '1.2.0'

which it displays somewhere in the tools Help system. The CHANGELOG file
says "Version 1.2".

The script contains a shebang that can become problematic, unless
it really works with both Python 2 and Python 3:

  #!/usr/bin/env python

https://fedorahosted.org/fpc/ticket/327
Older topic:
http://fedoraproject.org/wiki/Script_Interpreters_%28draft%29
https://www.redhat.com/archives/fedora-packaging/2009-July/msg00056.html


More information about the devel mailing list