fedora-review: 'Illegal return' warnings

Alec Leamas leamas.alec at gmail.com
Mon Oct 6 13:26:28 UTC 2014

On 2014-10-06 15:16, Florian Weimer wrote:
> On 10/05/2014 05:15 PM, Florian Weimer wrote:
>> On 10/04/2014 10:18 PM, Alec Leamas wrote:
>>> Hm.... seems that recent bash patch to fix the shellshock problem
>>> introduces this. Fedora-review relies on exported shell functions
>>> (export -f) and the bash fix changes the syntax for exported functions
>>> in an incompatible way.
>> It's the attempt at cleaning up the environment, see
>> /usr/share/fedora-review/plugins/shell_api.py:
>> unset $(env | sed -n 's/=.*//p')
>> With exported functions, that was fairly broken before (with multi-line
>> function definitions and “=” somewhere in the body), but after the bash
>> change, this is much more obvious and is even triggered by the exported
>> function in the environment-modules package.  It would have been
>> preferable to clean the environment either in the Python code, or wrap
>> the shell invocation with “env -i”.
> And indeed this had already been reported as a bug, completely 
> unrelated to exported functions:
>   <https://bugzilla.redhat.com/show_bug.cgi?id=1085761>


I shall try to have a  look at this. MIght take some time, though.


More information about the devel mailing list