when DEP-3 compliant patches in Fedora?

Neal Gompa ngompa13 at gmail.com
Fri Aug 28 12:51:12 UTC 2015


On Fri, Aug 28, 2015 at 8:44 AM, Florian Weimer <fweimer at redhat.com> wrote:

> On 08/28/2015 02:11 PM, Marcin Juszkiewicz wrote:
> > Hi
> >
> > I am building software for misc distributions for over 11 years. And so
> > far Fedora packages are the worst of those I played with (mostly
> > OpenEmbedded and Debian).
> >
> > Why? Because patches are mess. Let's take random one:
> >
> > @@ -108,7 +108,7 @@
> >                  M = int(max(r, g, b))
> >                  m = int(min(r, g, b))
> >                  val = (2 * M + r + g + b) / 5
> > -                p[:] = (val + r) / 2, (val + g) / 2, (val + b) / 2
> > +                #p[:] = (val + r) / 2, (val + g) / 2, (val + b) / 2
> >                  if alpha[y][x] >= 250:
> >                      alpha[y][x] = 255 - (M - m) * 3 / 4
> >          del pixels
> >
> > Who knows what it does and why? For some reason it has a name '64bitfix'
> > but why it is needed? Did upstream ever saw it? No idea.
> >
> > In Debian (or in OpenEmbedded) it is solved by implementing DEP-3 [1]
>
> In reality, here's what the Debian version of this patch looks like:
>
> <
> http://sources.debian.net/src/monsterz/0.7.1-8/debian/patches/010_64-bit-alignment-issues-with-python2.5.diff/
> >
>
> I'm not sure if it's all that more helpful, to be honest.  It does not
> follow DEP-3, sure, but neither do many other Debian packages.  Even
> some critical server packages still do not have any broken-out patches
> at all.
>
> (In general, if there is no upstream to contribute such fixes to, it's
> probably best not to ship such software at all.)
>
> --
> Florian Weimer / Red Hat Product Security
> --
> devel mailing list
> devel at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
> Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
>

​If patches are exported from Mercurial or Git, y​ou'd have all the
information you'd want. However, most people I know aren't working from the
hg/git repository when making packages. That said, I would seriously hope
there would be comments in the spec indicating why the patch is needed. I
know that when I have to make patches to packages, I will put comments
right above the patch source line with information about the patch.



-- 
真実はいつも一つ!/ Always, there's only one truth!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/devel/attachments/20150828/240a6046/attachment.html>


More information about the devel mailing list