Results of a test mass rebuild of rawhide/x86_64 with gcc-5.0.0-0.5.fc22

[Ralf Corsepius]

On 02/10/2015 06:22 AM, Marek Polacek wrote:
> On Mon, Feb 09, 2015 at 02:43:25PM -0700, Jerry James wrote:
>> On Sun, Feb 8, 2015 at 10:17 AM, Marek Polacek <polacek at redhat.com> wrote:
>>> bigloo-4.1a-6.2.fc22.src.rpm
>>> memstomp-0.1.4-15.fc22.src.rpm
>>>          build failure due to gnu11 change: -Wimplicit-int is turned on by default now,
>>>          which is the reason these packages didn't compile properly.  See the porting_to
>>>          document for more details.
>>
>> The bigloo failure had nothing to do with -Wimplicit-int.  One file
>> that should have been compiled with -fPIC wasn't.  I don't know why
>> this didn't cause problems before.  Fixed in Rawhide.
>
> IIRC bigloo contains various "autoconf" shell scripts with K&R code in
> them (that fail with -Werror now)

Remove these -Werrors and tell upstream to not use -Werror.
-Werror turns harmless warnings into errors.

As autoconf scripts are based on compilers issuing errors only on real 
errors and not on otherwise harmless warnings,  -Werror is not useful 
with autoconf scripts and is _guaranteed_ to break autoconf scripts, 
because the items GCC warns about are changing with each GCC-release and 
also depend on other factors (CFLAGS) in effect.

Ralf