Review Swap?

[Antonio Trande]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 07/08/2015 09:23 PM, Dave Johansen wrote:
> On Wed, Jul 8, 2015 at 10:15 AM, Antonio Trande
> <anto.trande at gmail.com <mailto:anto.trande at gmail.com>> wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
> 
> On 07/08/2015 07:08 PM, Dave Johansen wrote:
>> I have two reviews that have been waiting for a reviewer for a 
>> while. I would be willing to do a review swap but I would
>> probably have a slow turn around on my end (I'm currently on
>> vacation and only occasionally get time to do this sort of
>> thing). So if you're willing to swap or do the review, then
>> please let me know. cppformat:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1216279 hgsubversion:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1221459 Thanks, Dave
>> 
>> 
> 
> I'm willing to review both your packages.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1231427
> 
> 
> It looks like these two lines are unused and are causing problems 
> because qmake isn't available when they're run: %global qtinc
> %(qmake -query QT_INSTALL_PREFIX)/include %global qtlib   %(qmake
> -query QT_INSTALL_PREFIX)/lib
> 
> 

Please, leave comment in bugzilla directly.

- -- 
Antonio Trande

mailto: sagitter 'at' fedoraproject 'dot' org
http://fedoraos.wordpress.com/
https://fedoraproject.org/wiki/User:Sagitter
GPG Key: 0x565E653C
Check on https://keys.fedoraproject.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVnXmaAAoJEF5tK7VWXmU8aVEH/RrtWEZvdrilYvGmOXsUKcDz
qaeGtsMfpXdvXMCoKu7eSjD1Ul/LnDJLz/wMMtVkbEktzpXMo/XE61qGExih2ezL
v5DL+gGugVRTG+7UtbrsufBJl7xavc4LSjcTurY45599RMot+LZtTAJKvdLbavYd
NeF4qN8yePpNfFul0e+HBaJ7c8tiDlMULe4VYvocM39ZJqkkHDDGyZy+pLJ8/7p1
CJKUqbZhQv6e4errarVu32zK28+UNkhBkV04HZTGVlJUa8pzSmU2QimFsUSGy15y
oi5lt28xS94uszIqGDqyez9dcZMpifLjYXYMYibyM2OFYoiGMCBs7XcvKEa+MHQ=
=I9Rl
-----END PGP SIGNATURE-----