F23 Self Contained Change: RPM MPI Requires Provides -> Review request

Orion Poplawski orion at cora.nwra.com
Thu Jul 9 18:31:07 UTC 2015


On 07/08/2015 05:03 PM, Sandro Mani wrote:
> 
> 
> On 08.07.2015 22:28, Orion Poplawski wrote:
>> It appears to be sufficient to define this macro anywhere, not just in
>> elf.attr. So I think it could be added in to a rpm macros file in
>> openmpi/mpich-devel. 
> Ah cool, actually it seems to also work if I add it directly to mpi.attrs,
> meaning that all pieces are nicely confined in one place.

Agreed.

>> Also I think you need (64)? or (|64).
> Correct, fixed. I'm seeing this also in cmake:
> 
> $ grep '(64)' /usr/lib/rpm/fileattrs/cmake.attr
> %__cmake_path ^/usr/lib(64)/cmake/.*/.*(Config\.cmake|-config\.cmake)$
> 
> suppose it should be fixed there too.

Thanks.  Fixed in rawhide now.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion at nwra.com
Boulder, CO 80301                   http://www.nwra.com


More information about the devel mailing list