[HEADS UP] rpm-4.12.90 in rawhide

[Lubos Kardos]

The current behavior is right. Your install script insert files into buildroot
and these files are not listed in %files section.

Correctly you should replace this:

%files
%doc AUTHORS COPYING NEWS README
...

with this:

%files
%{_pkgdocdir}/AUTHORS
%{_pkgdocdir}/COPYNIG
%{_pkgdocdir}/NEWS
%{_pkgdocdir}/README
%{_pkgdocdir}/ChangeLog
%{_pkgdocdir}/TODO
...

Tag %doc followed by relative path of a file is used when you want rpm to copy
files from BUILD to BUILDROOT document directory but in your case this is done
by your install script.

Lubos


----- Original Message -----
> From: "Frantisek Kluknavsky" <fkluknav at redhat.com>
> To: devel at lists.fedoraproject.org
> Sent: Monday, July 27, 2015 3:55:53 PM
> Subject: Re: [HEADS UP] rpm-4.12.90 in rawhide
> 
> On 07/25/2015 11:18 AM, Remi Collet wrote:
> > Le 24/07/2015 15:49, Florian Festi a écrit :
> >> The freshly released rpm-4.12.90 aka rpm-4.13.0-alpha is going to hit
> >> rawhide soon. The two major new features are:
> >>
> >>   * Boolean (aka rich) dependencies to support more complicated relation
> >> between packages
> >>   * File Triggers - run scripts if files get installed in given paths -
> >> possibly to replace most of the regular - per package - scriptlets at
> >> some point in the future.
> >>
> >> But for now and for Fedora this update is more about testing and
> >> stabilizing the many smaller changes as far as they have not been ported
> >> back already.
> >>
> >> See the draft release notes for details:
> >> http://rpm.org/wiki/Releases/4.13.0
> >
> > It seems we have a regression (thanks Koschei)
> >
> > See https://kojipkgs.fedoraproject.org/work/tasks/4402/10474402/build.log
> >
> > In spec (which is quite common, I think)
> >
> > %doc imagick-3.1.2/{CREDITS,TODO,INSTALL}
> >
> > During %doc
> >
> > + cp -pr imagick-3.1.2/CREDITS imagick-3.1.2/TODO imagick-3.1.2/INSTALL
> > /builddir/build/BUILDROOT/php-pecl-imagick-3.1.2-3.fc24.i386/usr/share/doc/php-pecl-imagick
> > + exit 0
> > RPM build errors:
> > error: File not found:
> > /builddir/build/BUILDROOT/php-pecl-imagick-3.1.2-3.fc24.i386/usr/share/doc/php-pecl-imagick/{CREDITS,TODO,INSTALL}
> >      File not found:
> > /builddir/build/BUILDROOT/php-pecl-imagick-3.1.2-3.fc24.i386/usr/share/doc/php-pecl-imagick/{CREDITS,TODO,INSTALL}
> >
> >
> > Do you want me to file a bug ?
> >
> > Remi
> >
> >
> 
> 
> Hi,
> 
> there is another change involving %doc. A piece of libdvdread.spec: "
> %files
> %defattr(-,root,root,-)
> %doc AUTHORS COPYING NEWS README
> %{_libdir}/libdvdread.so.*
> 
> %files devel
> %defattr(-,root,root,-)
> %doc ChangeLog TODO
> ...
> "
> 
> With old rpm, files ChangeLog and TODO were included in both
> libdvdread.rpm and libdvdread-devel.rpm. With this new rpm, koji build
> fails with: "
> Installed (but unpackaged) file(s) found:
>     /usr/share/doc/libdvdread/ChangeLog
>     /usr/share/doc/libdvdread/TODO
> "
> 
> Which behavior is correct? I guess both are wrong. Should bugzillas be
> filed?
> 
> Have a nice day,
> 
> Fero
> --
> devel mailing list
> devel at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
> Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct