Boost updated to 1.58.0 in rawhide and f23

[Adam Williamson]

On Tue, 2015-07-28 at 14:49 +0100, Jonathan Wakely wrote:
> On 28/07/15 14:48 +0100, Jonathan Wakely wrote:
> > On 27/07/15 19:35 -0700, Adam Williamson wrote:
> > > On Mon, 2015-07-27 at 13:31 +0100, Jonathan Wakely wrote:
> > > > On 23/07/15 14:33 +0200, David Tardon wrote:
> > > > > Hi,
> > > > > 
> > > > > On Thu, Jul 23, 2015 at 02:27:33PM +0200, David Tardon wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > On Sat, Jul 18, 2015 at 12:46:51PM +0100, Jonathan Wakely 
> > > > > > wrote:
> > > > > > > Any problems rebuilding either open a bug or feel free to 
> > > > > > > email
> > > > > > > me or
> > > > > > > ping me on IRC (my freenode nick is 'redi') and I'll be 
> > > > > > > happy
> > > > > > > to help.
> > > > > > 
> > > > > > This is a work-in-progress list of FTBFS packages:
> > > > > > 
> > > > > > * Build failures:
> > > > > > 
> > > > > > - F23 + Rawhide
> > > > > > 
> > > > > > ledger
> > > > 
> > > > This patch is needed to make Ledger compile with Boost 1.58.0
> > > 
> > > I submitted a build using the patch you submitted as an upstream 
> > > PR -
> > > https://github.com/ledger/ledger/pull/422 - but it still failed:
> > > 
> > > https://kojipkgs.fedoraproject.org//work/tasks/9527/10499527/buil
> > > d.log
> > 
> > Yes, as well as my patch for #422 you still need the second half of
> > the patch for the upstream #417 (which was not reverted), which 
> > I've
> > attached to this mail.
> 
> Oh, and then it *still* fails because of unpackaged files, see
> https://kojipkgs.fedoraproject.org//work/tasks/1167/10501167/build.lo
> g
> which I did yesterday using the constness patch from my previous mail
> and my upstream fix for #422.

For the record - with many thanks to nirik - this appears to be due to
some shenanigans with RPM's handling of %doc:

https://bugzilla.redhat.com/show_bug.cgi?id=728959

in Ye Olde Olde Days, %doc ANY_RELATIVE_PATH would wipe %_pkgdocdir
before installing the listed files to it - so if you wanted to keep
stuff installed there during %install you couldn't use %doc in that
way, you had to do it yourself.

In Ye Somewhat Less Olde Days - between 2011 and four days ago - %doc
didn't do that any more, and would happily include any files that were
put in %_pkgdocdir during %install, without them needing to be listed
in %files.

For Rawhide, since four days ago (downstream - the change, I think,
arrived in rpm-4.12.90-1.fc24; it landed on upstream master in April),
we have a sort of happy medium apparently, where %doc does not clean
%_pkgdocdir but the 'unpackaged files' check does apply to it - so if
%install puts files there, you either have to delete them or list them
in %files. And that's what broke the build here; the package's %install
installs various things to %_pkgdocdir , but the %files section doesn't
list them. I'll fix that.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net