Applications missing from Fedora 23

[Zbigniew Jędrzejewski-Szmek]

On Sat, Sep 26, 2015 at 03:34:39PM +0200, Daniel Pocock wrote:
> On 26/09/15 15:22, Zbigniew Jędrzejewski-Szmek wrote:
> > On Sat, Sep 26, 2015 at 11:14:45AM +0100, Richard Hughes wrote:
> >> On 24 September 2015 at 19:13, Zbigniew Jędrzejewski-Szmek
> >> <zbyszek at in.waw.pl> wrote:
> >>> On Fri, Sep 18, 2015 at 11:28:44AM +0100, Richard Hughes wrote:
> >>>> postbooks: specified icon '/usr/share/postbooks/images/icon128x32.png'
> >>>> does not exist
> >>> The png is in the rpm... What's going on here?
> >>
> >> It's not in a standard search path for icons:
> >> https://github.com/hughsie/appstream-glib#what-is-an-application says:
> >>
> >>  - Icons MUST be installed in /usr/share/pixmaps/*,
> >> /usr/share/icons/*, /usr/share/icons/hicolor/*/apps/*, or
> >> /usr/share/${app_name}/icons/*
> >>
> >> The reason for that rule is two-fold:
> >>
> >> * when we build the metadata we don't actually decompress all the rpm
> >> contents, just the parts we're interested in (makes building about 50x
> >> faster as lzma is sloooow)
> >> * when we have a sandboxed future icons will need to be a standard
> >> location rather than spread over /usr
> >>
> >> In this case, it's probably enough to just add a symlink from
> >> /usr/share/postbooks/images/icon128x32.png to /usr/share/icons/ so
> >> that it gets extracted, although icon128x32.png doesn't sound terribly
> >> promising for a HiDPI icon.
> > Actually it's 128x128 pixels.
> > 
> > Thanks for the explanation.
> 
> Can you please clarify, are you asking me to create a symlink from the
> spec file or something else?  If you could provide a diff against the
> spec file that would be ideal.
IIUC, it is necessary to *move* the file to /usr/share/icons, and then
either update the code to load the icon from there, or symlink from
/usr/share/postbooks/images/ to /usr/share/icons. Updating the code
would of course be nicer.

> I agree the filename is confusing, if you like, this could be changed by
> sending a pull request on the upstream Github
Not volunteering to do that, sorry ;)

Zbyszek