[Fedora-electronic-lab] Re: [Fedora Electronic Lab] #23: Package qtdmm

[Fedora Electronic Lab]

#23: Package qtdmm
----------------------------+-----------------------------------------------
  Reporter:  zap            |       Owner:  sherry151
      Type:  task           |      Status:  assigned 
  Priority:  minor          |   Milestone:  Fedora 12
 Component:  analog design  |     Version:  devel    
Resolution:                 |    Keywords:           
----------------------------+-----------------------------------------------
Changes (by sherry151):

  * status:  new => assigned

Comment:

 Good work there zap. But there are a few things I would like to point out.

 # 1: Do you really need a .desktop patch because when I built qtdmm on my
 system, the existing .desktop in the source worked fine with the desktop-
 file-install in the %install section. Please check it and if the patch is
 not required, please remove it.

 # 2: Why is the srpm has packager name in its name. How are you building
 it? Your spec file does not show any packager tag and when I used it to
 build on my system, there was no packager name in the srpm name. Please
 make sure that you are using the correct spec file. Also, please abide by
 the Fedora package naming guidelines.
 http://fedoraproject.org/wiki/Packaging/NamingGuidelines

 # 3: Increase the release number every time you make some changes after a
 review. That will help track the changes easily.

 # 4: By separating blocks with an empty line what Chitlesh meant was that
 you should seperate the various logical blocks like the 'Name, Version,
 Release, Summary' and 'License,URL,Source0' etc. Also it might be a good
 practice to keep the various tags in vertical alignment. Use tab for this.
 I have reformatted your latest spec file for your understanding. I am
 uploading it here as an attachment. https://fedorahosted.org/fedora-
 electronic-lab/attachment/ticket/23/qtdmm.5.spec

 Keep up the good work. Also the spec file is almost ready. You cn go ahead
 and file a review request for this package. Follow this guide
 http://fedoraproject.org/wiki/PackageMaintainers/Join#Create_Your_Review_Request
 . Also go through this
 http://fedoraproject.org/wiki/PackageMaintainers/Join . Once you have
 submitted the review request, paste the link to the bug here.

-- 
Ticket URL: <https://fedorahosted.org/fedora-electronic-lab/ticket/23#comment:10>
Fedora Electronic Lab <https://fedorahosted.org/fedora-electronic-lab>
Design, Simulate and Program electronics.