[Fedora-join] Review Check

[Ankur Sinha]

Hi Sourav,

On Fri, 2012-10-26 at 08:54 -0700, Sourav Basu wrote:
> * Package consistently uses macro is (instead of hard-coded directory
> names)*

It implies that you make use of the rpm macros for directories as given
here[1] instead of using the actual directories themselves. For
instance, we use

%{__bindir} and _not_ the expansion: /usr/bin

These macros may evaluate differently on different fedora and epel
versions (read the link). The idea is simple: 

All binaries go into %{__bindir}, _however_ it's defined by rpm. If any
of these locations are modified (say, by the fedora packaging
committee), all that is required is a rebuild. 

[1] https://fedoraproject.org/wiki/Packaging:RPMMacros
-- 
Thanks, 
Warm regards,
Ankur: "FranciscoD"

Please only print if necessary. 

Looking to contribute to Fedora? Look here: https://fedoraproject.org/wiki/Fedora_Join_SIG

http://fedoraproject.org/wiki/User:Ankursinha
http://dodoincfedora.wordpress.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.fedoraproject.org/pipermail/fedora-join/attachments/20121027/dfd757cd/attachment.sig>