filelight-1.9rc2 kde port - can someone please review?

[Ben Boeckel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Neal Becker wrote:

> I am trying to update filelight to 1.9rc2, which ports to 
kde4.  Can someone
> please review my changes (I'm not very familiar with kde4 
packaging).
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1571154
> _______________________________________________
> fedora-kde mailing list
> fedora-kde at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/fedora-kde
> New to KDE4? - get help from http://userbase.kde.org

* rpmlint output:

% rpmlint filelight-*.rpm
filelight.src: W: mixed-use-of-spaces-and-tabs (spaces: line 45, 
tab: line 46)
filelight.x86_64: E: file-in-usr-marked-as-conffile 
/usr/share/config/filelightrc
filelight.x86_64: W: file-not-utf8 
/usr/share/doc/filelight-1.9/ChangeLog
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

Please fix these.

* I would recommend splitting BuildRequires over multiple lines 
for readability.

* kdelibs-devel -> kdelibs4-devel

* Use a patch instead of a sed script

* Use the cmake/make recipe on the wiki[1]

* %{_bindir} -> %{_kde4_bindir}

* Could you make and upstream a patch for the .desktop file 
installation? Run desktop-file-validate on them. (This should 
probably also be a macro...I'll add it to my wiki to-do list 
which includes a KDE4 Packaging Guidelines page).

Other than that, looks good. Thanks.

- --Ben

[1]https://fedoraproject.org/wiki/SIGs/KDE#Best_Practices
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkpzmuMACgkQiPi+MRHG3qRLOgCgpnf4BvRJ2fyciv64Tn+buot+
ulgAni6k5TgEnlfUTPETqP/tIId217t5
=ZFVQ
-----END PGP SIGNATURE-----