[Bug 501924] Review Request: mingw32-tcl - MinGW Windows Tool Command Language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501924





--- Comment #3 from Thomas Sailer <t.sailer at alumni.ethz.ch>  2009-05-21 11:16:32 EDT ---
(In reply to comment #2)

Thanks for taking! That was quick!

> This one is quite hard to read, due to the frequent use of macros. However, I
> don't think it can be done any other way, so I'll do my best to read through
> them.

I modified the native tcl package spec file. 

> The %files list contains some redundant entries:

Fixed.

> For readability, you might want to move this piece of code to the top of the
> .spec file:
>  # don't run "make test" by default
>  %{?_without_check: %define _without_check 0}
>  %{!?_without_check: %define _without_check 1}

This is again from the native spec file. I kept it there to minimize the
differences. So the %check section could probably completely go...

> Is the rename of the import libraries from .a to .dll.a really necessary?
> AFAIK, this is only needed for libtool based libraries (which tcl isn't)

I don't think the renaming is strictly necessary. I did it to make it extra
clear that the .a files are implibs, not static libraries...

> The native tcl package is now at version 8.5.7. You might want to update to
> that version too. See

Woohoo. Just when you think you're up to date :)
But there does not seem to be a successful build of 8.5.7 in koji. So I'm ahead
now :)

Updated:
Spec URL: http://sailer.fedorapeople.org/mingw32-tcl.spec
SRPM URL: http://sailer.fedorapeople.org/mingw32-tcl-8.5.7-1.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.