[Bug 961408] Review Request: mingw-tesseract - MinGW Windows tesseract-ocr library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=961408

Michael Cronenworth <mike at cchtml.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #2 from Michael Cronenworth <mike at cchtml.com> ---
$ rpmlint mingw-tesseract-3.02.02-2.fc20.src.rpm \
          mingw32-tesseract-3.02.02-2.fc18.noarch.rpm \
          mingw32-tesseract-static-3.02.02-2.fc18.noarch.rpm \
          mingw32-tesseract-tools-3.02.02-2.fc18.noarch.rpm \
          mingw64-tesseract-3.02.02-2.fc18.noarch.rpm \
          mingw64-tesseract-static-3.02.02-2.fc18.noarch.rpm 
          mingw64-tesseract-tools-3.02.02-2.fc18.noarch.rpm \
          mingw32-tesseract-debuginfo-3.02.02-2.fc18.noarch.rpm \
          mingw64-tesseract-debuginfo-3.02.02-2.fc18.noarch.rpm
mingw-tesseract.src: W: spelling-error Summary(en_US) ocr -> OCR, cor, or
mingw-tesseract.src: W: spelling-error %description -l en_US ocr -> OCR, cor,
or
mingw-tesseract.src: W: invalid-url Source0:
http://leptonica.googlecode.com/files/tesseract-ocr-3.02.02.tar.gz HTTP Error
404: Not Found
mingw32-tesseract.noarch: W: spelling-error Summary(en_US) ocr -> OCR, cor, or
mingw32-tesseract.noarch: W: spelling-error %description -l en_US ocr -> OCR,
cor, or
mingw32-tesseract-static.noarch: W: spelling-error Summary(en_US) ocr -> OCR,
cor, or
mingw32-tesseract-static.noarch: W: spelling-error %description -l en_US ocr ->
OCR, cor, or
mingw32-tesseract-static.noarch: W: no-documentation
mingw32-tesseract-tools.noarch: W: spelling-error Summary(en_US) ocr -> OCR,
cor, or
mingw32-tesseract-tools.noarch: W: spelling-error %description -l en_US ocr ->
OCR, cor, or
mingw32-tesseract-tools.noarch: W: no-documentation
mingw64-tesseract.noarch: W: spelling-error Summary(en_US) ocr -> OCR, cor, or
mingw64-tesseract.noarch: W: spelling-error %description -l en_US ocr -> OCR,
cor, or
mingw64-tesseract-static.noarch: W: spelling-error Summary(en_US) ocr -> OCR,
cor, or
mingw64-tesseract-static.noarch: W: spelling-error %description -l en_US ocr ->
OCR, cor, or
mingw64-tesseract-static.noarch: W: no-documentation
mingw64-tesseract-tools.noarch: W: spelling-error Summary(en_US) ocr -> OCR,
cor, or
mingw64-tesseract-tools.noarch: W: spelling-error %description -l en_US ocr ->
OCR, cor, or
mingw64-tesseract-tools.noarch: W: no-documentation
mingw32-tesseract-debuginfo.noarch: E: debuginfo-without-sources
mingw64-tesseract-debuginfo.noarch: E: debuginfo-without-sources
9 packages and 0 specfiles checked; 2 errors, 19 warnings.

The only warning that is of concern is the download link. Looks like a typo.
Should be:
http://tesseract-ocr.googlecode.com/files/tesseract-ocr-%{version}.tar.gz

+ OK
! needs attention

+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
  native Fedora package
+ The package contains the license file (COPYING.lib)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  26adc8154f0e815053816825dde246e6  Downloads/tesseract-ocr-3.02.02.tar.gz
  26adc8154f0e815053816825dde246e6  SOURCES/tesseract-ocr-3.02.02.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
+ Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

-----------
Summary:

- The review is for "tesseract" when upstream is "tesseract-ocr". I see the
native Fedora package is "tesseract" so I will pass it here.
- Just fix the SOURCE0 url and you are good to go!

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T8lCdgz0rf&a=cc_unsubscribe