[Bug 979564] Review Request: mingw-sane-backends - MinGW package for SANE

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=979564

Sandro Mani <manisandro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Sandro Mani <manisandro at gmail.com> ---
All ok, approved!

One small remark concerning exe files, just for info: FPC approved revised
guidelines stating that exes not needed for proper functionality of the
libraries should either be discarded from the package, or put in a subpackage,
see https://lists.fedoraproject.org/pipermail/mingw/2013-May/006865.html
(apparently the updated guidelines are not yet on the wiki?). But I'll leave
for you to decide if you want to change anything.

(BuildRoot and defattr: I was looking at
$ wget
http://michael.cronenworth.com/RPMS/mingw-sane-backends-1.0.23-1.fc18.src.rpm
$ rpm2cpio mingw-sane-backends-1.0.23-1.fc18.src.rpm | cpio -id
$ grep BuildRoot mingw-sane-backends.spec 
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
$ grep defattr mingw-sane-backends.spec
%defattr(-,root,root)
%defattr(-,root,root,-)
%defattr(-,root,root)
%defattr(-,root,root,-)
)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZfB4eD8AeS&a=cc_unsubscribe