[Bug 472418] Review Request: xmbdfed - Bitmap Font Editor

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 10 19:39:19 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


Lucian Langa <cooly at gnome.eu.org> changed:

           What    |Removed                     |Added
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Lucian Langa <cooly at gnome.eu.org>  2008-12-10 14:39:18 EDT ---

OK  source files match upstream:
        27872bb7473e5d64d9a24281ae6ad3d9  xmbdfed-4.7.tar.bz2
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
OK  summary is OK.
OK  description is OK.
OK  dist tag is present.
OK  build root is OK.
OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
NOT OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (rawhide, x86_64).
OK  package installs properly.
OK  debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires are sane:
        xmbdfed = 4.7-2.fc11
        xmbdfed(x86-64) = 4.7-2.fc11
OK  %check is not present; no test suite upstream.
    I was able to run the program fine after adding correct Requires
N/A no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code, not content.
OK  documentation is small, so no -doc subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.
OK  desktop file present and correctly installed

- Please add desktop-file-utils as dependency (correctly installing desktop

- Please consider preserving timestamps on installed files
- Please also keep the classical order of files for fedora spec files

APPROVED. (but please fix BR)

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the fonts-bugs mailing list