[Bug 457947] Review Request: oldstandard-sfd-fonts - Old Standard Fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457947





--- Comment #24 from Martin-Gomez Pablo <pablo.martin-gomez at laposte.net>  2008-12-28 16:22:16 EDT ---
* I don't understand the following code, eventually, it should be
<string>serif</string>, no ?
<match target="pattern">
 <test name="family">
<string>sans-serif</string>
</test>
</match>

* Put the following codes in section %prep after %setup (and not in %build or
in %install):
--------
for txt in OFL* ; do
 sed 's/\r//' $txt > $txt.new
 touch -r $txt $txt.new
 mv $txt.new $txt
done

install -m 644 -p %{SOURCE2} .
--------

* Do the %post and the %postun are useful ? I just find them in some fonts and
no wiki page about it. Nicolas, an explanation ?  

* Now, the change needed by the new guideline:
- Add the following in the right place : 
BuildRequires: fontpackages-devel
Requires:      fontpackages-filesystem 
- Remove "%define fontdir  %{_datadir}/fonts/%{fontname}" and replace all the
"%{fontdir}" by "%{_fontdir}" (it's now an official macro)
- Replace "%config(noreplace) %{fontconfdir}/60-%{fontname}.conf" and
"%{fontdir}/*.ttf" by "%_font_pkg -f 60-%{fontname}.conf *.ttf"
(- There is something else with templatedir macro, but i don't understand how
it work, i'll see)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.