[Bug 449356] Refactor gfxPangoFontGroup for user fonts

[bugzilla-daemon at mozilla.org]

Do not reply to this email.  You can add comments to this bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=449356


Karl Tomlinson (:karlt) <mozbugz at karlt.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346583|0                           |1
        is obsolete|                            |




--- Comment #23 from Karl Tomlinson (:karlt) <mozbugz at karlt.net>  2008-11-06 20:30:46 PST ---
Created an attachment (id=346830)
 --> (https://bugzilla.mozilla.org/attachment.cgi?id=346830)
what eventually landed

Thanks, Vlad for your help.

Two more uninitialized variables:

--- a/gfx/thebes/src/gfxPangoFonts.cpp
+++ b/gfx/thebes/src/gfxPangoFonts.cpp
@@ -872,7 +872,7 @@ gfxFcPangoFontSet::SortPreferredFonts()
     if (truncateMarker != NULL && fontSet) {
         nsAutoRef<FcFontSet> truncatedSet(FcFontSetCreate());

-        for (int f; f < fontSet->nfont; ++f) {
+        for (int f = 0; f < fontSet->nfont; ++f) {
             FcPattern *font = fontSet->fonts[f];
             if (font == truncateMarker)
                 break;
@@ -1127,7 +1127,7 @@ gfx_pango_fontset_get_font(PangoFontset
 {
     gfxPangoFontset *self = GFX_PANGO_FONTSET(fontset);

-    PangoFont *result;
+    PangoFont *result = NULL;

     FcPattern *baseFontPattern = NULL;
     if (self->mBaseFont) {

-- 
Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.