[Bug 457947] Review Request: oldstandard-fonts - Old Standard Fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457947


Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |petersen at redhat.com




--- Comment #2 from Jens Petersen <petersen at redhat.com>  2008-10-05 23:45:17 EDT ---
The spec file and package name differ.  Shouldn't the package be named
69oldstandard as you also originally submitted?

rpmlint says:

69oldstandard-fonts.src: E: description-line-too-long Old Standard is an
attempt to provide a high quality font, suitable for classical, biblical and
medieval studies as well as for general-purpose typesetting in languages which
use Greek or Cyrillic script,
69oldstandard-fonts.src: E: no-changelogname-tag
69oldstandard-fonts.src: W: non-coherent-filename
oldstandard-fonts-1-1.fc9.src.rpm 69oldstandard-fonts-1-1.fc9.src.rpm
error checking signature of oldstandard-fonts-1-1.fc9.src.rpm
1 packages and 0 specfiles checked; 2 errors, 1 warnings.


Do you really need these:

    <match target="pattern">
        <test name="family">
            <string>sans-serif</string>
        </test>
        <test name="lang" compare="contains">
            <string>jp</string>
        </test>
        <edit name="lang" mode="prepend" binding="strong">
            <string>en</string>
        </edit>
    </match>

    <alias>
        <family>sans-serif</family>
        <prefer>
            <family>DejaVu Sans</family>
        </prefer>
    </alias>

in the fontconfig file?

The srpm file also seems to be corrupted I am afraid:
69oldstandard-fonts-1-1.fc9
warning: user Package does not exist - using root
warning: group Package does not exist - using root
warning: user Package does not exist - using root
warning: group Package does not exist - using root
warning: user Ankur does not exist - using root
warning: group Ankur does not exist - using root
error: unpacking of archive failed on file
/home/package-review/oldstandard-fonts/oldstand-1.0.ttf.zip;48e9897c: cpio:
read

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.