[Bug 457955] Review Request: bonvenocf-fonts - BonvenoCF font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457955


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |nicolas.mailhot at laposte.net
               Flag|                            |fedora-review?,
                   |                            |needinfo?(sanjay_ankur at yaho
                   |                            |o.co.in)




--- Comment #3 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2008-10-26 14:03:25 EDT ---
Ok, I'll take this review

1. Please do not use 69bonvenocf-fonts as package name. Use bonvenocf-fonts or
cf-bonveno-fonts (cf-bonveno-fonts is probably better as it will give you a
Crude Factory prefix to use with other Crude Factory fonts)

2. Please use install -dm 755 instead of mkdir as suggested by the official
spec template

3. You can remove the "for example" comment

4. 69 is a bit low as fontconfig prefix, 64 is probably sufficient for a latin
font

5. Use 1.1 as version since upstream provides a nicely versionned archive

6. Since upstream provides sfd sources, please build the ttf from source using
fontforge. You have an example of sfd building in bug #467507 for example

7. the font is GPLv2 + font exception (cf README)

8. Why do you want to disable hinting for this font?

9. Why do you want to prepend en to the font?

10. Please reformat your xml files with xmllint --format before submission so
they are nicely indented with the same rules as other font packages

11. When you've written fontconfig rules you're happy with it's always a good
idea to send them upstream to be included in the font next releases

12. Please fine a way to add Barry Schwartz' name in the summary (flattering
font designers is good for our interactions with them)

14. Please update http://fedoraproject.org/wiki/BonvenoCF_font to remove the
font from the wishlist (change the Catzgorization). You should not need
packaging powers to do that, just a FAS account

All in all, that's not too bad an attempt for a first font package. Fix all
this, and I'll sponsor you if that's still needed

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.