[Bug 501854] Review Request: lcdf-typetools - The LCDF Typetools for manipulating OpenType fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501854


Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-06-10 14:52:23 EDT ---
I'm done reviewing this. There are two minor issues to be resolved:

- rpmlint is silent

- There are certain files in the source, such as
   include/lcdf/hashmap.cc
   include/lcdf/vector.cc
   include/lcdf/clp.h
   liblcdf/string.cc
   liblcdf/error.cc
   liblcdf/vectorv.cc
   liblcdf/clp.c
   liblcdf/straccum.cc
that are under MIT license. But since during the compilation, they are linked
to GPL parts of the code, and since GPL is stricter than MIT, the overall
license as GPLv2+ is acceptable.

- koji rawhide build is fine:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=1403904

* The directory
   %{_datadir}/lcdf-typetools/
is unowned! This needs attention.

* Please include the COPYING file in %doc, as required by the guidelines.


Please do these changes before you commit.

-------------------------------------------------
This package (lcdf-typetools) is APPROVED by oget
-------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.