[Bug 486977] Review Request: gnu-free-fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486977





--- Comment #4 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2009-03-05 15:13:58 EDT ---
We're getting there :)

1. you still have at least one %define in common_desc (probably did not notice
it because you've reordered the template)

2.you still have a needless group declaration in your common package

3. you should simplify your subpackage names (for example use
%{fontname}-mono-fonts instead of %{fontname}-freemono-fonts). Repeating the
project name does not really help users.

4. you need to drop
Requires:  gnu-free-fonts-freemono-fonts = %{version}-%{release}
Requires:  gnu-free-fonts-freesans-fonts = %{version}-%{release}
Requires:  gnu-free-fonts-freeserif-fonts = %{version}-%{release}

Obsoletes: freefont < 20090104-2

from your main package

5. you probably don't need to obsolete package names that were never pushed to
user systems, this obsolete data will never be used

6. you don't need
%dir %{_fontdir}
in your common package

7. you can unroll the for loop, but if you do so make sure you don't reference
the for variable anymore

8. your fontconfig rule filenames need to start with a number to work (in your
case 60 is probably fine, see
/usr/share/fontconfig/templates/fontconfig-priorities.txt)

9. your fontconfig rules won't work if you just put the font name everywhere
blindly. See /usr/share/fontconfig/templates/fontconfig-generics.txt and 
/usr/share/fontconfig/templates/basic-font-template.txt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.