[Bug 491596] libmagic does not recognize pcf.gz files as font files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491596





--- Comment #2 from Panu Matilainen <pmatilai at redhat.com>  2009-03-23 07:55:42 EDT ---
Created an attachment (id=336274)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=336274)
Plug fd leak from pipe()

Ok, the issue is easily reproducable with just file(1) itself, any .zip file
seems to do and run "valgrind --track-fds=yes file -z <zipfile>". 

For example:
[pmatilai at localhost ~]$ valgrind --track-fds=yes file -z
/usr/lib64/openoffice.org/basis3.0/share/config/images.zip
==11616== Memcheck, a memory error detector.
==11616== Copyright (C) 2002-2008, and GNU GPL'd, by Julian Seward et al.
==11616== Using LibVEX rev 1884, a library for dynamic binary translation.
==11616== Copyright (C) 2004-2008, and GNU GPL'd, by OpenWorks LLP.
==11616== Using valgrind-3.4.1, a dynamic binary instrumentation framework.
==11616== Copyright (C) 2000-2008, and GNU GPL'd, by Julian Seward et al.
==11616== For more details, rerun with: -v
==11616== 
/usr/lib64/openoffice.org/basis3.0/share/config/images.zip: PNG image, 16 x 16,
8-bit/color RGBA, non-interlaced (Zip archive data, at least v2.0 to extract)
==11616== 
==11616== FILE DESCRIPTORS: 4 open at exit.
==11616== Open file descriptor 4:
==11616==    at 0x3E20AD8BD7: pipe (in /lib64/libc-2.9.so)
==11616==    by 0x4C2F882: file_zmagic (compress.c:383)
==11616==    by 0x4C34DA3: file_buffer (funcs.c:206)
==11616==    by 0x4C272C6: file_or_fd (magic.c:357)
==11616==    by 0x401228: process (file.c:431)
==11616==    by 0x401CDB: main (file.c:343)
==11616== 

The attached one-liner seems to be sufficient to fix, but check by yourself,
I'm recovering from a nasty stomach flu and not feeling exactly bright and
sharp atm...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.