[Bug 528675] Review Request: knm-new-fonts - 12x12 JIS X 0208 Bitmap font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528675


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |nicolas.mailhot at laposte.net
               Flag|                            |fedora-review?,
                   |                            |needinfo?(tagoh at redhat.com)




--- Comment #1 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2009-10-14 14:33:39 EDT ---
1. technically each file here is a "font" so the summary should probably be 
12x12 JIS X 0208 bitmap fonts

2.
JIS X 0208 is a character set that contains Kanji characters mostly
often used.
⇒ The JIS X 0208 character set contains the most often used Kanji glyphs.

3. your provides/obsoletes are probably too complex, rpmlint complains
knm-new-fonts.noarch: W: self-obsoletion knm_new <= 1.1-16 obsoletes knm_new =
1.1-16

IMHO you should drop Provides completely, repoquery says nothing requires 
knm_new or knm-new-fonts in Fedora

4. you should put 
/etc/X11/fontpath.d/knm-new
and
/usr/share/fonts/knm-new/fonts.dir
in a separate legacy subpackage

5. The fonts declare themselves as "fixed", therefore please rename the package
knm-new-fixed-fonts (we want the font name to appear in the package name). Not
sure if using the same name as many other fonts is a good idea, but I guess I
don't care a lot

6. fc-query complains
Can't query face 0 of font file /usr/share/fonts/knm_new/knm12pb.pcf.gz
Can't query face 0 of font file /usr/share/fonts/knm_new/knm12p.pcf.gz
Can't query face 0 of font file /usr/share/fonts/knm_new/knmzn12xb.pcf.gz
Can't query face 0 of font file /usr/share/fonts/knm_new/knmzn12x.pcf.gz

You should open a bug against fontconfig to have it investigated. This is not
normal.

7. It would be nice to include a fontconfig file for the font

8. I don't think it's good style to mix macros for some commands (%{__ln_s},
%{_bindir}/mkfontdir) and not others. The current convention seems to write
plain unmacroized commands with no explicit path

Anyway that's all for the review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.