[Bug 526058] Review Request: sil-scheherazade-fonts - SIL Scheherazade Arabic Script Unicode Font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526058


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |nicolas.mailhot at laposte.net
               Flag|                            |fedora-review?,
                   |                            |needinfo?(hedayat at grad.com)




--- Comment #2 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2009-09-30 17:14:53 EDT ---
Thanks for looking at this font! SIL fonts are usually high quality, it's a
shame we do not package all of them yet like other distros do (hint hint)

Package review:

1. current best practice is to avoid using the package name in the summary,
please reword it without "SIL Scheherazade" (I know it was not always like
this, and we haven't changed evey previous package yet). The reason is that
package tools already display the package name next to the summary

2. (minor) you don't really have to use Caps Before Every Word (though that's a
matter of preference)

3. (minor) I'm not sure it's a good idea to include your second description §.
All this technical mumbo-jumbo is likely to frighten normal users

4. it's not a good idea to depend on dos2unix for txt file conversion, you can
usually attain the same results using just sed and iconv. Your package does not
build as a result in mock, since dos2unix is not present in the buildroot
+ dos2unix FONTLOG.txt OFL-FAQ.txt OFL.txt
/var/tmp/rpm-tmp.BzkuMA: line 29: dos2unix: command not found

http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8

If you intend to maintain more packages later it's a good idea to setup a mock
instance on your system to test for this kind of mistake
http://fedoraproject.org/wiki/Projects/Mock

5. And lastly, please add some fontconfig rules. Just the default set +
Monotype Naskh should be enough, unless there is something else you feel would
help users. You have standard templates and documentation in fontpackages-devel
(though the F11 version may be a little old, install the latest one it will
work just fine in F11 too)
http://koji.fedoraproject.org/koji/packageinfo?packageID=7288

And that's all for now

NEEDINFO till you answer those

(PS if you're not member of the packaging group yet, I can sponsor you, but
I'll require 2-3 good font package submissions before; we've streamlined the
process so much a single submission is not enough to judge if someone will
become a good packager anymore)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.