[Bug 615850] Review Request: oflb-roadstencil-fonts - Roadstencil Fonts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615850

Ankur Sinha <sanjay.ankur at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Ankur Sinha <sanjay.ankur at gmail.com> 2010-07-19 06:51:45 EDT ---
+ OK
? ISSUE
- NA

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum:

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
? Package has a correct %clean section.
? Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.

SHOULD Items:

+ Should build in mock.
- Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
- Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1. Please correct the ChangeLog, you have the version wrong

"1.001-9" ? extra zero ?

XX MUSTFIX XX

2. rpmlint output:


[Ankur at localhost SPECS]$ rpmlint oflb-roadstencil-fonts.spec
../SRPMS/oflb-roadstencil-fonts-1.0-9.fc13.src.rpm
/var/lib/mock/fedora-rawhide-i386/result/*.rpm
oflb-roadstencil-fonts.spec: W: no-cleaning-of-buildroot %install
oflb-roadstencil-fonts.spec: W: no-cleaning-of-buildroot %clean
oflb-roadstencil-fonts.spec: W: no-buildroot-tag
oflb-roadstencil-fonts.spec: W: no-%clean-section
oflb-roadstencil-fonts.spec: W: invalid-url Source0:
http://openfontlibrary.org/people/andyfitz/andyfitz_-_roadstencil.otf HTTP
Error 404: Not Found
oflb-roadstencil-fonts.src: W: invalid-url URL:
http://openfontlibrary.org/media/files/andyfitz/237 HTTP Error 404: Not Found
oflb-roadstencil-fonts.src: W: no-cleaning-of-buildroot %install
oflb-roadstencil-fonts.src: W: no-cleaning-of-buildroot %clean
oflb-roadstencil-fonts.src: W: no-buildroot-tag
oflb-roadstencil-fonts.src: W: no-%clean-section
oflb-roadstencil-fonts.src: W: invalid-url Source0:
http://openfontlibrary.org/people/andyfitz/andyfitz_-_roadstencil.otf HTTP
Error 404: Not Found
oflb-roadstencil-fonts.noarch: W: incoherent-version-in-changelog 1.001-9
['1.0-9.fc14', '1.0-9']
oflb-roadstencil-fonts.noarch: W: invalid-url URL:
http://openfontlibrary.org/media/files/andyfitz/237 HTTP Error 404: Not Found
oflb-roadstencil-fonts.src: W: invalid-url URL:
http://openfontlibrary.org/media/files/andyfitz/237 HTTP Error 404: Not Found
oflb-roadstencil-fonts.src: W: no-cleaning-of-buildroot %install
oflb-roadstencil-fonts.src: W: no-cleaning-of-buildroot %clean
oflb-roadstencil-fonts.src: W: no-buildroot-tag
oflb-roadstencil-fonts.src: W: no-%clean-section
oflb-roadstencil-fonts.src: W: invalid-url Source0:
http://openfontlibrary.org/people/andyfitz/andyfitz_-_roadstencil.otf HTTP
Error 404: Not Found
3 packages and 1 specfiles checked; 0 errors, 19 warnings.


Ignorable errors. URL error because of dead upstream.

Other than the version in the changelog, the package is OK. 

Please fix that before you create a CVS module & build for rawhide etc.

XXX APPROVED XXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.