[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579369

--- Comment #5 from René Ribaud <rene.ribaud at free.fr> 2010-05-13 13:58:48 EDT ---
Hi Parag,

Thanks for the review, I have fixed the package.

> Suggestions:
> 1) remove following comments from SPEC
> #ln -s /dev/null \
> #      %{buildroot}%{_fontconfig_confdir}/%{fontconf}

Removed

> 
> 2) Give newline after each changelog entry and also between BuildRequires: line
> and %description line
> 

Done

> 3) Instead of adding BuildRequires: dos2unix, you can do following in %prep.
> ==========================================================
> for file in copyright.txt readme_en_v2.014.txt; do
>  sed "s|\r||g" $file > $file.new && \
>  touch -r $file $file.new && \
>  mv $file.new $file
> done
> ===========================================================
> 
>  This will help not to increase build time dependency on dos2unix package.    

Done, I used "sed -i" instead of dos2unix.


Anyway we will find the updated package here :

Spec URL: http://uggla.free.fr/rpmbuild/SPECS/kanjistrokeorders-fonts.spec
SRPM URL:
http://uggla.free.fr/rpmbuild/SRPMS/12/kanjistrokeorders-fonts-2.014-4.fc12.src.rpm

RPMLINT output :
----------------
[ctb at uggla SRPMS]$ rpmlint kanjistrokeorders-fonts-2.014-4.fc12.src.rpm
kanjistrokeorders-fonts.src: W: spelling-error %description -l en_US kanji ->
Kantian, Kanpur, Kansas
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[ctb at uggla noarch]$ rpmlint kanjistrokeorders-fonts-2.014-4.fc12.noarch.rpm
kanjistrokeorders-fonts.noarch: W: spelling-error %description -l en_US kanji
-> Kantian, Kanpur, Kansas
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


KOJI output :
-------------

I have built the package with koji on all architectures for F12, F13 and
rawhide.
You can look at the F12 result here :
http://koji.fedoraproject.org/koji/taskinfo?taskID=2186156

F13 here :


and F14 here :


Waiting for your feedbacks.

Best regards.
René

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.