[Bug 860249] Review Request: adobe-sourcecodepro-fonts - A set of mono-spaced OpenType fonts designed for coding environments

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=860249

--- Comment #14 from Michael J Gruber <mjg at fedoraproject.org> ---
(In reply to comment #12)
> (In reply to comment #9)
> > (In reply to comment #7)
> > 
> > 
> > rpmlint gives 2 errors on that rpm. The lines in the spec are too long, and
> > the source URL does not resolve.
> 
> I'll take a look at that.
> 
> > 
> > Is this really a straight adaption of the source sans spec?
> 
> Yep, just changed Sans to Code in a few places.  I'll attach the diff once I
> fix the rpmlint errors.
> 

An srpm built from the current sans package repo in fedora gives no errors,
btw.

> > Have you filed a packaging request, Matt? We don't want another dupe.
> 
> No, I found this packaging request and noticed that Tobias's URLs weren't
> resolving, so I added the url's to this bug for the packages that I had
> already built.

Note that "raw" URLs would have been more helpful. I'm probably not the only
one who uses save link/wget/curl/etc on them just to get github's html/xml.

Since Tobias was the first to submit the package in bz I suggest giving him the
time to polish his spec. My informal review is there already, but he needs a
sponsor and he's been turning the appropriate bz wheels already, which is good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.