[Bug 1124070] Review Request: pcaro-hermit-fonts - Monospace fonts for programming

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1124070



--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> ---
Suggestions:
1) spec file name should not contain any version or release. I suppose its a
typo in the initial comment for Spec URL.

2) If you are not planning to add this package to EPEL6 then remove following
from spec

   a) Group tag is now optional and can be removed.

   b) "rm -rf %{buildroot}" is not needed anymore as its done automatically by
rpmbuild 

   c) similarly %clean section is also not needed anymore

3) %prep should contain only
%setup -q

4) Though there is no compilation or building of binary files happening, you
can include empty %build to let rpmlint happy

5) Don't add extra empty spaces in the spec file like one you have line 59

6) I think you can if wanted keep the priority of fontconfig file to 69.
Generally 60-69 numbers are used for "generic aliases, map generic->family" and
you have the same fontconfig rule.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wEHPLTHYEg&a=cc_unsubscribe