[Bug 1138321] Review Request: reneebeanie-fonts - Renie Beanie fonts by James Grieshaber

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 9 15:54:21 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1138321



--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> ---
We got naming issue resolved as "we don't need to add `google-` prefix". 

Review:

+ Package builds fine in mock in F22

- rpmlint on generated rpms gave output
reeniebeanie-fonts.noarch: W: spelling-error Summary(en_US) Renie -> Rene,
Renee, Genie
reeniebeanie-fonts.noarch: W: spelling-error %description -l en_US Reene ->
Renee, Rene, Reese
reeniebeanie-fonts.noarch: W: invalid-url URL:
https://code.google.com/p/googlefontdirectory/source/browse/ofl/reneebeanie
HTTP Error 404: Not Found
reeniebeanie-fonts.src: W: spelling-error Summary(en_US) Renie -> Rene, Renee,
Genie
reeniebeanie-fonts.src: W: spelling-error %description -l en_US Reene -> Renee,
Rene, Reese
reeniebeanie-fonts.src: W: invalid-url URL:
https://code.google.com/p/googlefontdirectory/source/browse/ofl/reneebeanie
HTTP Error 404: Not Found
reeniebeanie-fonts.src: E: specfile-error warning: line 52: second %files
2 packages and 0 specfiles checked; 1 errors, 6 warnings.

- source verified with upstream as (sha256sum)
=> Don't know how to download source archive

+ License is OFL and included in its own text file OFL.txt

- fontconfig file looks good

+ follows fonts packaging guidelines except additional %files

Suggestions:
1) if you execute
rpm -E %_font_pkg

you will see this macro already added %files. so you should remove %files
written explicitly in spec file.

2) use cursive instead of handwriting in fontconfig file see more about this in
/usr/share/fontconfig/templates/fontconfig-generics.txt

3) How do you created source archive? Maybe you should add comment above
Source0: tag and write how one can obtain same tarball

4) and version looks 1.000 and not 1.00

5) URL should be http://www.google.com/fonts/specimen/Reenie+Beanie

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S3lsiVMcym&a=cc_unsubscribe


More information about the fonts-bugs mailing list