[Bug 1142422] Review Request: unifrakturmaguntia-fonts - UnifrakturMaguntia font by Peter Wiegel

bugzilla at redhat.com bugzilla at redhat.com
Wed Sep 17 05:51:10 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1142422



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---
Review:

+ Package builds fine in mock in F22

- rpmlint on generated rpms gave output
unifrakturmaguntia-fonts.noarch: W: spelling-error %description -l en_US
Ansmann -> Klansman, Clansman
unifrakturmaguntia-fonts.noarch: W: spelling-error %description -l en_US glyphs
-> glyph, glyph s
unifrakturmaguntia-fonts.src: W: spelling-error %description -l en_US Ansmann
-> Klansman, Clansman
unifrakturmaguntia-fonts.src: W: spelling-error %description -l en_US glyphs ->
glyph, glyph s
unifrakturmaguntia-fonts.src: E: specfile-error warning: line 66: second %files
2 packages and 0 specfiles checked; 1 errors, 4 warnings.

=> Can be fixed easily

+ source verified with upstream as (sha256sum)
packaged source:
5119394196ee30f00aeb4a8f22b910fa3ba70a4bb871b4ca216738ba26359152
upstream source:
5119394196ee30f00aeb4a8f22b910fa3ba70a4bb871b4ca216738ba26359152

+ License is OFL and included in its own text file OFL.txt

+ fontconfig file looks good

+ follows fonts packaging guidelines 

- extra %files in spec in srpm.
==> looks like you forgot to update srpm but only updates spec. you can import
fixed srpm

few more issues are
1) you don't need in %prep
rm -rf UnifrakturMaguntia.2014-07-06

2) Download Source URL should be
http://downloads.sourceforge.net/project/unifraktur/fonts/UnifrakturMaguntia.2014-07-06.zip

3) I will suggest use version as 0. So that we will avoid year duplication
Version:       0
Release:       0.1.%{source_date}%{?dist}

4) %summary should be
Font that provide a Fraktur typeface that may be embedded on websites. 

Note This font is created by  j. 'mach' wust, Gerrit Ansmann and Georg Duffner
and not by Peter Wiegel as per FontLog.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PGBjVFI31v&a=cc_unsubscribe


More information about the fonts-bugs mailing list