[Bug 1187337] Review Request: oflb-coval-fonts - Derivation of other free of charge fonts

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1187337

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: coval-fonts |Review Request:
                   |- font derived from         |oflb-coval-fonts -
                   |sans-serif                  |Derivation of other free of
                   |                            |charge fonts



--- Comment #13 from Parag AN(पराग) <panemade at gmail.com> ---
Once you get sponsorship in packager group you can add the wiki pages later on.

You need to keep the package name and summary same in this bug review summary
also. I have changed it now.

Some issues with new update
1) You changed the summary. This is only one font being packaged and not set of
fonts. So, you cannot say its font family. Better to keep summary as
Summary:  Derivation of other free of charge fonts

2) I see you removed the description from metainfo file and just put the
summary. You should add more information there or same information that is in
%description of spec file. Just see appstream-util command output also says
• style-invalid         : <p> is too short

You can use there
  <description>
    <p>
     Coval font is a free-to-use non-commercial font.
     Language Support: Basic Cyrillic, Basic Latin, Euro.
    </p>
  </description>

2) Another thing I see that you are changing version number which is not good.
if you look into font metadata then there is version number specified as
"1.000". You need to use that. Check metadata using command "ttname Coval.otf".

You need to keep same version that upstream provides and based on that version
your changes happens with releases in Release tag. So, your Changelog should
look like this

* Wed Feb 04 2015 Carlos Morel-Riquelme <empateinfinito at fedoraproject.org> -
1.000-3.20150122
- Update the priority LGC font
- Fix the metainfo.xml

* Wed Feb 04 2015 Carlos Morel-Riquelme <empateinfinito at fedoraproject.org> -
1.000-2.20150122
- Update the spec file
- Fix the metainfo.xml

* Wed Feb 04 2015 Carlos Morel-Riquelme <empateinfinito at fedoraproject.org> -
1.000-1.20150122
- Fix the spec file
- Fix the fontconfig.conf

* Thu Jan 29 2015 Carlos Morel-Riquelme <empateinfinito at gmail.com> - 0.1-1
- Initial version
- Add metainfo file to show this font in gnome-software

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dAryDvNNW7&a=cc_unsubscribe