[Bug 1079090] Review Request: layla-fonts - A collection of traditional Arabic fonts

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1079090



--- Comment #36 from Mohammed Isam <mohammed_isam1984 at yahoo.com> ---
(In reply to Jonathan Dieter from comment #35)
> Package Review
> ==============
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/fonts,
>      /etc/fonts/conf.d, /usr/share/fontconfig/conf.avail,
>      /usr/share/fontconfig, /etc/fonts
> 
>      Please add Requires: fontpackages-filesystem to the -common subpackage
> 

I added the Requires line to the spec. I don't need to add the individual
ownerships to the %files directory, do I?

> [!]: Each %files section contains %defattr if rpm < 4.4
> 
>      Note: %defattr present but not needed

Not fixed. Honestly I don't get it. My %files section doesn't contain any
%defattr?

> 
> [!]: License field in the package spec file matches the actual license.
> 
>      Package license and license included in tarball is GPLv3+, but,
> according 
>      to ttname.log, licenses in ttf files are all SIL OFL 1.1.  Since you're 
>      also upstream for this package, I'd recommend sticking with SIL OFL 1.1.
>      

Added the OFL license file (actually, three files according to the OFL
directions). Removed the GPL file and updated the License field in the spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3bUp7EGdgT&a=cc_unsubscribe