[Bug 1181725] Re-Review Request (epel5): fontpackages - Common directory and macro definitions used by font packages

bugzilla at redhat.com bugzilla at redhat.com
Fri Feb 13 07:47:41 UTC 2015 

https://bugzilla.redhat.com/show_bug.cgi?id=1181725



--- Comment #3 from Akira TAGOH <tagoh at redhat.com> ---
Some needs to be fixed/improved. otherwise looks good to me. see the below for
details.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
* MUST items
  * rm-fr %{buildroot} at %install is present.
  * %defattr is present.

* SHOULD items
  * Buildroot is present.
  * %clean is present.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.

===== SHOULD items =====

Generic:
[!]: Buildroot is not present
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[ ]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: SourceX tarball generation or download is documented.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: fontpackages-filesystem-1.44-1.fc21.2.noarch.rpm
          fontpackages-devel-1.44-1.fc21.2.noarch.rpm
          fontpackages-tools-1.44-1.fc21.2.noarch.rpm
          fontpackages-1.44-1.fc21.2.src.rpm
fontpackages-filesystem.noarch: W: no-documentation
fontpackages-tools.noarch: W: no-manual-page-for-binary ttfcoverage
fontpackages-tools.noarch: W: no-manual-page-for-binary repo-font-audit
fontpackages-tools.noarch: W: no-manual-page-for-binary fix-font-naming
fontpackages-tools.noarch: W: no-manual-page-for-binary filter-unicover
fontpackages-tools.noarch: W: no-manual-page-for-binary compare-repo-font-audit
fontpackages-tools.noarch: W: no-manual-page-for-binary filter-langcover
fontpackages-tools.noarch: W: no-manual-page-for-binary filter-fontlint
fontpackages.src:18: W: macro-in-comment %{name}
fontpackages.src:18: W: macro-in-comment %{name}
fontpackages.src:18: W: macro-in-comment %{version}
fontpackages.src: W: invalid-url Source0: fontpackages-1.44.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 12 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
fontpackages-tools (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/perl
    curl
    fedora-packager
    fontconfig
    fontforge
    make
    mutt
    perl(Font::TTF::Font)
    perl(Getopt::Std)
    perl(Unicode::UCD)
    rpmlint
    yum-utils

fontpackages-devel (rpmlib, GLIBC filtered):
    config(fontpackages-devel)
    fontconfig
    fontpackages-filesystem
    rpmdevtools

fontpackages-filesystem (rpmlib, GLIBC filtered):



Provides
--------
fontpackages-tools:
    fontpackages-tools

fontpackages-devel:
    config(fontpackages-devel)
    fontpackages-devel

fontpackages-filesystem:
    fontpackages-filesystem



Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1181725
Buildroot used: fedora-21-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=da7596fAAO&a=cc_unsubscribe

More information about the fonts-bugs mailing list